From cfa7708b57caafb131b8e4839243ad232fe54c7f Mon Sep 17 00:00:00 2001 From: RMidhunSuresh Date: Wed, 10 Nov 2021 18:51:46 +0530 Subject: [PATCH] Use type imports --- src/logging/BaseLogger.ts | 9 ++++++--- src/logging/LogFilter.ts | 2 +- src/logging/LogItem.ts | 5 +++-- 3 files changed, 10 insertions(+), 6 deletions(-) diff --git a/src/logging/BaseLogger.ts b/src/logging/BaseLogger.ts index fb91e77b..99a8f9b7 100644 --- a/src/logging/BaseLogger.ts +++ b/src/logging/BaseLogger.ts @@ -15,9 +15,12 @@ See the License for the specific language governing permissions and limitations under the License. */ -import {LogItem, LabelOrValues, FilterCreator, LogCallback} from "./LogItem"; -import {LogLevel, LogFilter, LogLevelOrNull} from "./LogFilter"; -import {Platform} from "../platform/web/Platform.js"; +import {LogItem} from "./LogItem"; +import {LogLevel, LogFilter} from "./LogFilter"; +import type {FilterCreator, LabelOrValues, LogCallback} from "./LogItem"; +import type {LogLevelOrNull} from "./LogFilter"; +// todo: should this import be here just for getting the type? should it instead be done when Platform.js --> Platform.ts? +import type {Platform} from "../platform/web/Platform.js"; export abstract class BaseLogger { diff --git a/src/logging/LogFilter.ts b/src/logging/LogFilter.ts index f13a6179..476bca0e 100644 --- a/src/logging/LogFilter.ts +++ b/src/logging/LogFilter.ts @@ -14,7 +14,7 @@ See the License for the specific language governing permissions and limitations under the License. */ -import {LogItem} from "./LogItem"; +import type {LogItem} from "./LogItem"; export enum LogLevel { All = 1, diff --git a/src/logging/LogItem.ts b/src/logging/LogItem.ts index 4fdf8ada..2e95813a 100644 --- a/src/logging/LogItem.ts +++ b/src/logging/LogItem.ts @@ -15,8 +15,9 @@ See the License for the specific language governing permissions and limitations under the License. */ -import {BaseLogger} from "./BaseLogger"; -import {LogLevel, LogLevelOrNull, LogFilter} from "./LogFilter"; +import {LogLevel, LogFilter} from "./LogFilter"; +import type {LogLevelOrNull} from "./LogFilter"; +import type {BaseLogger} from "./BaseLogger"; type LogItemWithLabel = { l: string;