Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

dont use lookbehind in regular expressions, safari & older firefoxes choke on them

Browse source
This commit is contained in:
Bruno Windels 2021-12-08 18:00:27 +01:00
parent c87628b614
commit c8b0354d07
2 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
codestyle.md
View file

@ -8,3 +8,5 @@
otherwise it becomes hard to remember what was a default/named export otherwise it becomes hard to remember what was a default/named export
- should we return promises from storage mutation calls? probably not, as we don't await them anywhere. only read calls should return promises? - should we return promises from storage mutation calls? probably not, as we don't await them anywhere. only read calls should return promises?
- we don't anymore - we don't anymore
- don't use these features, as they are not widely enough supported.
- [lookbehind in regular expressions](https://caniuse.com/js-regexp-lookbehind)

2
src/platform/web/Platform.js
View file

@ -163,7 +163,7 @@ export class Platform {
// Make sure that loginToken does not end up in the logs // Make sure that loginToken does not end up in the logs
const transformer = (item) => { const transformer = (item) => {
if (item.e?.stack) { if (item.e?.stack) {
item.e.stack = item.e.stack.replace(/(?<=\/\?loginToken=).+/, "<snip>"); item.e.stack = item.e.stack.replace(/(?<=\/\?loginToken=).+/, "?loginToken=<snip>");
} }
return item; return item;
}; };