From c5bdc8ba053104ca2c00d3c1a4dc07766e56cb17 Mon Sep 17 00:00:00 2001 From: Bruno Windels Date: Wed, 12 Jun 2019 21:57:48 +0200 Subject: [PATCH] more notes --- doc/RELATIONS.md | 4 ++++ doc/SENDING.md | 2 ++ 2 files changed, 6 insertions(+) diff --git a/doc/RELATIONS.md b/doc/RELATIONS.md index 3b5afa38..b1146b6c 100644 --- a/doc/RELATIONS.md +++ b/doc/RELATIONS.md @@ -6,3 +6,7 @@ SyncWriter will need to resolve the related remote id to a [fragmentId, eventInd The timeline can take incoming events from both the SendQueue and SyncWriter, and see if their related to fragmentId/eventIndex is in view, and then update it? alternatively, SyncWriter/SendQueue could have a section with updatedEntries apart from newEntries? + +SendQueue will need to pass the non-sent state (redactions & relations) about an event that has it's remote echo received to the SyncWriter so it doesn't flash while redactions and relations for it still have to be synced. + +Also, related ids should be processed recursively. If event 3 is a redaction of event 2, a reaction to event 1, all 3 entries should be considered as updated. diff --git a/doc/SENDING.md b/doc/SENDING.md index 578317e9..68fc394f 100644 --- a/doc/SENDING.md +++ b/doc/SENDING.md @@ -196,3 +196,5 @@ PendingEventStore get() update() remove() + +make sure to handle race between /sync and /send (e.g. /sync with sent event may come in before /send returns)