Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

prevent duplicate redactions from distorting reaction local echo

Browse source
This commit is contained in:
Bruno Windels 2021-06-24 13:14:54 +02:00
parent 061f44f475
commit c46c330efb
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/matrix/room/sending/SendQueue.js
View file

@ -226,6 +226,14 @@ export class SendQueue {
} }
async enqueueRedaction(eventIdOrTxnId, reason, log) { async enqueueRedaction(eventIdOrTxnId, reason, log) {
const existingRedaction = this._pendingEvents.array.find(pe => {
return pe.eventType === REDACTION_TYPE &&
(pe.relatedTxnId === eventIdOrTxnId || pe.relatedEventId === eventIdOrTxnId);
});
if (existingRedaction) {
log.set("already_redacting", true);
return;
}
let relatedTxnId; let relatedTxnId;
let relatedEventId; let relatedEventId;
if (isTxnId(eventIdOrTxnId)) { if (isTxnId(eventIdOrTxnId)) {
@ -393,6 +401,18 @@ export function tests() {
assert.equal(index, 1); assert.equal(index, 1);
assert.equal(txnId, value.txnId); assert.equal(txnId, value.txnId);
} }
},
"duplicate redaction gets dropped": async assert => {
const queue = new SendQueue({
roomId: "!abc",
storage: await createMockStorage(),
hsApi: new MockHomeServer().api
});
assert.equal(queue.pendingEvents.length, 0);
await queue.enqueueRedaction("!event", null, new NullLogItem());
assert.equal(queue.pendingEvents.length, 1);
await queue.enqueueRedaction("!event", null, new NullLogItem());
assert.equal(queue.pendingEvents.length, 1);
} }
} }
} }