Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Unmount child views correctly

Browse source 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
This commit is contained in:
RMidhunSuresh 2021-07-14 17:30:59 +05:30
parent 2502c4024a
commit c073d4c0d0
1 changed files with 5 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/platform/web/ui/general/LazyListView.js
View file

@ -130,15 +130,18 @@ export class LazyListView extends ListView {
} }
return array; return array;
} }
_renderElementsInRange() { _renderElementsInRange() {
const { topCount, renderCount, bottomCount } = this._renderRange; const { topCount, renderCount, bottomCount } = this._renderRange;
const paddingTop = topCount * this._itemHeight; const paddingTop = topCount * this._itemHeight;
const paddingBottom = bottomCount * this._itemHeight; const paddingBottom = bottomCount * this._itemHeight;
const renderedItems = this._itemsFromList(topCount, topCount + renderCount); const renderedItems = this._itemsFromList(topCount, topCount + renderCount);
console.log(renderedItems);
this._root.style.paddingTop = `${paddingTop}px`; this._root.style.paddingTop = `${paddingTop}px`;
this._root.style.paddingBottom = `${paddingBottom}px`; this._root.style.paddingBottom = `${paddingBottom}px`;
this._root.innerHTML = ""; for (const child of this._childInstances) {
child.root().remove();
child.unmount();
}
this._renderItems(renderedItems); this._renderItems(renderedItems);
} }