Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Packages Projects Releases Wiki Activity

Add explaining comment

Browse source
This commit is contained in:
RMidhunSuresh 2022-04-13 13:39:20 +05:30
parent 825c9847fe
commit bf0cdcd3f1
1 changed files with 14 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
scripts/build-plugins/rollup-plugin-build-themes.js
View file

@ -128,6 +128,11 @@ module.exports = function buildThemes(options) {
async load(id) { async load(id) {
if (isDevelopment) { if (isDevelopment) {
/**
* To load the theme during dev, we need to take a different approach because emitFile is not supported in dev.
* We solve this by resolving virtual file "@theme/name/variant" into the necessary css import.
* This virtual file import is removed when hydrogen is built (see transform hook).
*/
if (id.startsWith(resolvedVirtualModuleId)) { if (id.startsWith(resolvedVirtualModuleId)) {
let [theme, variant, file] = id.substr(resolvedVirtualModuleId.length).split("/"); let [theme, variant, file] = id.substr(resolvedVirtualModuleId.length).split("/");
if (theme === "default") { if (theme === "default") {
@ -174,11 +179,17 @@ module.exports = function buildThemes(options) {
if (isDevelopment) { if (isDevelopment) {
return; return;
} }
// Removes develop-only script tag; this cannot be done in transformIndexHtml hook. /**
const devScriptTag = /<script type="module"> import "@theme\/.+"; <\/script>/; * Removes develop-only script tag; this cannot be done in transformIndexHtml hook because
* by the time that hook runs, the import is added to the bundled js file which would
* result in a runtime error.
*/
const devScriptTag =
/<script type="module"> import "@theme\/.+"; <\/script>/;
if (id.endsWith("index.html")) { if (id.endsWith("index.html")) {
const htmlWithoutDevScript = code.replace(devScriptTag, ""); const htmlWithoutDevScript = code.replace(devScriptTag, "");
return htmlWithoutDevScript return htmlWithoutDevScript;
} }
}, },