From b37a586094aa301b1396b74293dfe769a4991770 Mon Sep 17 00:00:00 2001
From: Bruno Windels <brunow@element.io>
Date: Fri, 5 Mar 2021 17:04:18 +0100
Subject: [PATCH] add clarification why this doesn't need to also check member
 changes

---
 src/matrix/room/Room.js | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/matrix/room/Room.js b/src/matrix/room/Room.js
index 88552ca0..671db2a7 100644
--- a/src/matrix/room/Room.js
+++ b/src/matrix/room/Room.js
@@ -266,6 +266,9 @@ export class Room extends EventEmitter {
         // fetch new members while we have txn open,
         // but don't make any in-memory changes yet
         let heroChanges;
+        // if any hero changes their display name, the summary in the room response
+        // is also updated, which will trigger a RoomSummary update
+        // and make summaryChanges non-falsy here
         if (summaryChanges?.needsHeroes) {
             // room name disappeared, open heroes
             if (!this._heroes) {