Minimize manual dom manipulation where possible

This commit is contained in:
RMidhunSuresh 2021-12-09 22:59:02 +05:30
parent 61f4d0719f
commit 99f4eb6843

View file

@ -27,8 +27,8 @@ export class ReplyPreviewView extends TemplateView {
_renderError({ error, avatar, senderName }) { _renderError({ error, avatar, senderName }) {
const errorMessage = this._getErrorMessage(error); const errorMessage = this._getErrorMessage(error);
const reply = avatar && senderName? this._renderReplyHeader(avatar, senderName) : tag.blockquote(); const children = [tag.span({ className: "statusMessage" }, errorMessage), tag.br()];
reply.append(tag.span({ className: "statusMessage" }, errorMessage), tag.br()); const reply = avatar && senderName? this._renderReplyHeader(avatar, senderName, children) : tag.blockquote(children);
return reply; return reply;
} }
@ -52,10 +52,12 @@ export class ReplyPreviewView extends TemplateView {
return reply; return reply;
} }
_renderReplyHeader(avatar, displayName) { _renderReplyHeader(avatar, displayName, children) {
return tag.blockquote([ return tag.blockquote([
tag.a({ className: "link", href: "#" }, "In reply to"), tag.a({ className: "link", href: "#" }, "In reply to"),
tag.a({ className: "pill", href: "#" }, [renderStaticAvatar(avatar, 12), displayName]), tag.br() tag.a({ className: "pill", href: "#" }, [renderStaticAvatar(avatar, 12), displayName]),
tag.br(),
...children
]); ]);
} }
} }