Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Add explaining comment

Browse source 
Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
This commit is contained in:
RMidhunSuresh 2021-07-12 14:44:55 +05:30
parent f05574f579
commit 96e2bb0b1a
1 changed files with 9 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/platform/web/ui/general/LazyListView.js
View file

@ -44,6 +44,10 @@ class ItemRange {
} }
normalize(idx) { normalize(idx) {
/*
Since we don't render the entire list, the index we use to do dom
manipulation or access childInstances will be different.
*/
return idx - this.topCount; return idx - this.topCount;
} }
} }
@ -73,14 +77,15 @@ export class LazyListView extends ListView {
const intersectRange = range.expand(this._overflowMargin); const intersectRange = range.expand(this._overflowMargin);
const renderRange = range.expand(this._overflowItems); const renderRange = range.expand(this._overflowItems);
const listHasChangedSize = !!this._renderRange && this._list.length !== this._renderRange.totalSize(); const listHasChangedSize = !!this._renderRange && this._list.length !== this._renderRange.totalSize();
console.log("currentRange", range); // console.log("currentRange", range);
console.log("renderRange", renderRange); // console.log("renderRange", renderRange);
console.log("intersectRange", intersectRange); // console.log("intersectRange", intersectRange);
console.log("LastRenderedRange", this._renderRange); // console.log("LastRenderedRange", this._renderRange);
// only update render Range if the list has shrunk/grown and we need to adjust padding OR // only update render Range if the list has shrunk/grown and we need to adjust padding OR
// if the new range + overflowMargin isn't contained by the old anymore // if the new range + overflowMargin isn't contained by the old anymore
if (listHasChangedSize || !this._renderRange || !this._renderRange.contains(intersectRange)) { if (listHasChangedSize || !this._renderRange || !this._renderRange.contains(intersectRange)) {
console.log("New render change"); console.log("New render change");
console.log("scrollTop", this._parent.scrollTop);
this._renderRange = renderRange; this._renderRange = renderRange;
this._renderElementsInRange(); this._renderElementsInRange();
} }