Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

non-persisted queued items don't have an id yet, find them by ref equality

Browse source
This commit is contained in:
Bruno Windels 2021-11-17 11:08:29 +01:00
parent f93bdd962a
commit 90d7b73dd4
1 changed files with 7 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/logging/IDBLogger.ts
View file

@ -152,12 +152,14 @@ export class IDBLogger extends BaseLogger {
const txn = db.transaction(["logs"], "readwrite");
const logs = txn.objectStore("logs");
for (const item of items) {
const queuedIdx = this._queuedItems.findIndex(i => i.id === item.id);
if (queuedIdx === -1) {
// todo: isn't id optional? do we need further checks here
logs.delete(item.id!); // resolve questionable use of non-null assertion operator?
if (typeof item.id === "number") {
logs.delete(item.id);
} else {
this._queuedItems.splice(queuedIdx, 1);
// assume the (non-persisted) object in each array will be the same
const queuedIdx = this._queuedItems.indexOf(item);
if (queuedIdx === -1) {
this._queuedItems.splice(queuedIdx, 1);
}
}
}
await txnAsPromise(txn);