Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Packages Projects Releases Wiki Activity

Remove await within loop

Browse source
This commit is contained in:
RMidhunSuresh 2022-07-21 12:05:10 +05:30
parent 7feaa479c0
commit 8d766ac504
1 changed files with 11 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
scripts/build-plugins/rollup-plugin-build-themes.js
View file

@ -51,12 +51,20 @@ function addThemesToConfig(bundle, manifestLocations, defaultThemes) {
*/ */
async function generateIconSourceMap(icons, manifestLocation) { async function generateIconSourceMap(icons, manifestLocation) {
const sources = {}; const sources = {};
const fileNames = [];
const promises = [];
const fs = require("fs").promises; const fs = require("fs").promises;
for (const icon of Object.values(icons)) { for (const icon of Object.values(icons)) {
const [location] = icon.split("?"); const [location] = icon.split("?");
const resolvedLocation = path.resolve(__dirname, "../../", manifestLocation, location); const resolvedLocation = path.resolve(__dirname, "../../", manifestLocation, location);
const iconData = await fs.readFile(resolvedLocation); const iconData = fs.readFile(resolvedLocation);
const svgString = iconData.toString(); promises.push(iconData);
const fileName = path.basename(resolvedLocation);
fileNames.push(fileName);
}
const results = await Promise.all(promises);
for (let i = 0; i < results.length; ++i) {
const svgString = results[i].toString();
const result = optimize(svgString, { const result = optimize(svgString, {
plugins: [ plugins: [
{ {
@ -68,8 +76,7 @@ async function generateIconSourceMap(icons, manifestLocation) {
], ],
}); });
const optimizedSvgString = result.data; const optimizedSvgString = result.data;
const fileName = path.basename(resolvedLocation); sources[fileNames[i]] = optimizedSvgString;
sources[fileName] = optimizedSvgString;
} }
return sources; return sources;
} }