Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Fix bug which caused subviews to not re-render

Browse source
This commit is contained in:
Kegan Dougal 2021-12-07 15:20:45 +00:00
parent 1b6d9db7cd
commit 7f653ab531
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/platform/web/ui/session/leftpanel/LeftPanelView.js
View file

@ -70,6 +70,10 @@ export class LeftPanelView extends TemplateView {
vm.loadRoomRange(range); vm.loadRoomRange(range);
}, },
shouldRecreateItem: (value, oldValue) => { shouldRecreateItem: (value, oldValue) => {
return true;
// TODO: We used to just recreate the item if the underlying view model was swapped out e.g ph->room
// but there is also a need to recreate items on room->room transitions (to re-make the
// subviews), so just always recreate views for now.
const isOldRoom = oldValue instanceof RoomTileViewModel; const isOldRoom = oldValue instanceof RoomTileViewModel;
const isNewRoom = value instanceof RoomTileViewModel; const isNewRoom = value instanceof RoomTileViewModel;
return isOldRoom != isNewRoom; return isOldRoom != isNewRoom;