Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Merge pull request #664 from vector-im/bwindels/onlylogsummarykeys

Browse source 
dont log summary valued, as they can contain PII
This commit is contained in:
Bruno Windels 2022-02-11 18:41:26 +01:00 committed by GitHub
commit 75e2618f70
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/matrix/room/Room.js
View file

@ -158,7 +158,7 @@ export class Room extends BaseRoom {
summaryChanges = this._summary.writeData(summaryChanges, txn); summaryChanges = this._summary.writeData(summaryChanges, txn);
} }
if (summaryChanges) { if (summaryChanges) {
log.set("summaryChanges", summaryChanges.diff(this._summary.data)); log.set("summaryChanges", summaryChanges.changedKeys(this._summary.data));
} }
// fetch new members while we have txn open, // fetch new members while we have txn open,
// but don't make any in-memory changes yet // but don't make any in-memory changes yet

13
src/matrix/room/RoomSummary.js
View file

@ -203,16 +203,11 @@ export class SummaryData {
this.cloned = copy ? true : false; this.cloned = copy ? true : false;
} }
diff(other) { changedKeys(other) {
const props = Object.getOwnPropertyNames(this); const props = Object.getOwnPropertyNames(this);
return props.reduce((diff, prop) => { return props.filter(prop => {
if (prop !== "cloned") { return prop !== "cloned" && this[prop] !== other[prop]
if (this[prop] !== other[prop]) { });
diff[prop] = this[prop];
}
}
return diff;
}, {});
} }
cloneIfNeeded() { cloneIfNeeded() {