From 74fb15e426c549f3ff3d29c8d9aead918298fac4 Mon Sep 17 00:00:00 2001 From: Bruno Windels Date: Wed, 17 Nov 2021 12:54:44 +0100 Subject: [PATCH] add future todo note --- src/logging/IDBLogger.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/logging/IDBLogger.ts b/src/logging/IDBLogger.ts index 621359dc..96147ca1 100644 --- a/src/logging/IDBLogger.ts +++ b/src/logging/IDBLogger.ts @@ -51,6 +51,7 @@ export class IDBLogger extends BaseLogger { this._flushInterval = this._platform.clock.createInterval(() => this._tryFlush(), flushInterval); } + // TODO: move dispose to ILogger, listen to pagehide elsewhere and call dispose from there, which calls _finishAllAndFlush dispose(): void { window.removeEventListener("pagehide", this, false); this._flushInterval.dispose();