Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Don't cache members that haven't been written yet - fixes #271

Browse source
This commit is contained in:
Bruno Windels 2021-04-08 12:56:24 +02:00
parent f5db6babf2
commit 6f37c232f7
1 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/matrix/room/timeline/persistence/MemberWriter.js
View file

@ -91,9 +91,6 @@ export class MemberWriter {
}); });
if (memberEvent) { if (memberEvent) {
member = RoomMember.fromMemberEvent(this._roomId, memberEvent); member = RoomMember.fromMemberEvent(this._roomId, memberEvent);
// adding it to the cache, but not storing it for now;
// we'll do that when we get to the event
this._cache.set(member);
} }
} }
return member; return member;
@ -222,5 +219,14 @@ export function tests() {
assert.equal(change.member.membership, "join"); assert.equal(change.member.membership, "join");
assert.equal(txn.members.get(alice).displayName, "Alice"); assert.equal(txn.members.get(alice).displayName, "Alice");
}, },
"newly joined member causes a change with lookup done first": async assert => {
const event = createMemberEvent("join", alice, "Alice");
const writer = new MemberWriter(roomId);
const txn = createStorage();
const member = await writer.lookupSenderMember(event, [event], txn);
assert(member);
const change = await writer.writeTimelineMemberEvent(event, txn);
assert(change);
},
}; };
} }