Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

No need to check if icons are already written

Browse source
This commit is contained in:
RMidhunSuresh 2022-04-05 15:26:00 +05:30
parent 2dd655cd9a
commit 6d724e27e7
2 changed files with 5 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
scripts/postcss/css-url-to-variables.js
View file

@ -56,15 +56,7 @@ function addResolvedVariablesToRootSelector(root, { Rule, Declaration }) {
function populateMapWithIcons(map, cssFileLocation) { function populateMapWithIcons(map, cssFileLocation) {
const location = cssFileLocation.match(/(.+)\/.+\.css/)?.[1]; const location = cssFileLocation.match(/(.+)\/.+\.css/)?.[1];
const sharedObject = map.get(location); const sharedObject = map.get(location);
if (sharedObject?.["icon"]) { sharedObject["icon"] = Object.fromEntries(urlVariables);
/**
* This postcss plugin is going to run on all theme variants of a single theme.
* But we only really need to populate the map once since theme variants only differ
* by the values of the base-variables and we don't care about values here.
*/
return;
}
map.set(location, { ...sharedObject, "icon": Object.fromEntries(urlVariables) });
} }
/* * /* *

5
scripts/postcss/tests/css-url-to-variables.test.js
View file

@ -50,6 +50,7 @@ module.exports.tests = function tests() {
}, },
"map is populated with icons": async (assert) => { "map is populated with icons": async (assert) => {
const compiledVariables = new Map(); const compiledVariables = new Map();
compiledVariables.set("/foo/bar", { "derived-variables": ["background-color--darker-20", "accent-color--lighter-15"] });
const inputCSS = `div { const inputCSS = `div {
background: no-repeat center/80% url("../img/image.svg?primary=main-color--darker-20"); background: no-repeat center/80% url("../img/image.svg?primary=main-color--darker-20");
} }
@ -61,7 +62,9 @@ module.exports.tests = function tests() {
"icon-url-1": "/home/foo/bar/cool.svg?primary=blue&secondary=green", "icon-url-1": "/home/foo/bar/cool.svg?primary=blue&secondary=green",
}; };
await postcss([plugin({compiledVariables})]).process(inputCSS, { from: "/foo/bar/test.css", }); await postcss([plugin({compiledVariables})]).process(inputCSS, { from: "/foo/bar/test.css", });
assert.deepEqual(expectedObject, compiledVariables.get("/foo/bar")["icon"]); const sharedVariable = compiledVariables.get("/foo/bar");
assert.deepEqual(["background-color--darker-20", "accent-color--lighter-15"], sharedVariable["derived-variables"]);
assert.deepEqual(expectedObject, sharedVariable["icon"]);
} }
}; };
}; };