From 66b4f9bfe5fea25f51b689aec3e7608c5c8108f0 Mon Sep 17 00:00:00 2001
From: RMidhunSuresh <hi@midhun.dev>
Date: Wed, 1 Dec 2021 16:09:42 +0530
Subject: [PATCH] LogItem --> ILogItem

---
 src/logging/types.ts                | 1 +
 src/matrix/net/HomeServerRequest.ts | 7 +++----
 2 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/src/logging/types.ts b/src/logging/types.ts
index 01755960..9e6e1210 100644
--- a/src/logging/types.ts
+++ b/src/logging/types.ts
@@ -50,6 +50,7 @@ export interface ILogItem {
     ensureRefId(): void;
     catch(err: Error): Error;
     serialize(filter: LogFilter, parentStartTime: number | undefined, forced: boolean): ISerializedItem | undefined;
+    finish(): void;
 }
 
 export interface ILogger {
diff --git a/src/matrix/net/HomeServerRequest.ts b/src/matrix/net/HomeServerRequest.ts
index ca3912e5..ea5d2e40 100644
--- a/src/matrix/net/HomeServerRequest.ts
+++ b/src/matrix/net/HomeServerRequest.ts
@@ -17,7 +17,7 @@ limitations under the License.
 
 import {HomeServerError, ConnectionError} from "../error.js";
 import type {RequestResult} from "../../platform/web/dom/request/fetch.js";
-import type {LogItem} from "../../logging/LogItem";
+import type {ILogItem} from "../../logging/types";
 
 export interface IHomeServerRequest {
     abort(): void;
@@ -25,13 +25,12 @@ export interface IHomeServerRequest {
 }
 
 export class HomeServerRequest implements IHomeServerRequest {
-    // todo: Shouldn't log be of type ILogItem; but ILogItem does not have finish method
-    private readonly _log?: LogItem;
+    private readonly _log?: ILogItem;
     private _sourceRequest?: RequestResult;
     // as we add types for expected responses from hs, this could be a generic class instead
     private readonly _promise: Promise<any>;
 
-    constructor(method: string, url: string, sourceRequest: RequestResult, log?: LogItem) {
+    constructor(method: string, url: string, sourceRequest: RequestResult, log?: ILogItem) {
         this._log = log;
         this._sourceRequest = sourceRequest;
         this._promise = sourceRequest.response().then(response => {