Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

make pushUrl silent again

Browse source
This commit is contained in:
Bruno Windels 2020-10-09 16:58:53 +02:00
parent 41c1c9a6c3
commit 4ae622bdd3
1 changed files with 18 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/ui/web/dom/History.js
View file

@ -20,9 +20,14 @@ export class History extends BaseObservableValue {
constructor() {
super();
this._boundOnHashChange = null;
this._expectSetEcho = false;
}
_onHashChange() {
if (this._expectSetEcho) {
this._expectSetEcho = false;
return;
}
this.emit(this.get());
}
@ -37,7 +42,19 @@ export class History extends BaseObservableValue {
}
pushUrl(url) {
document.location.hash = this.urlAsPath(url);
const hash = this.urlAsPath(url);
// important to check before we expect an echo
// as setting the hash to it's current value doesn't
// trigger onhashchange
if (hash === document.location.hash) {
return;
}
// this operation is silent,
// so avoid emitting on echo hashchange event
if (this._boundOnHashChange) {
this._expectSetEcho = true;
}
document.location.hash = hash;
}
urlAsPath(url) {