Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

getActiveTheme should never return undefined

Browse source 
Instead it should throw an error.

This is useful for when we do setTheme(await getActiveTheme()) because
setTheme expects a string.
This commit is contained in:
RMidhunSuresh 2022-05-23 12:45:32 +05:30
parent 8b2299852e
commit 4474458f4b
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
src/platform/web/ThemeLoader.ts
View file

@ -58,7 +58,7 @@ export class ThemeLoader {
return Object.keys(this._themeMapping); return Object.keys(this._themeMapping);
} }
async getActiveTheme(): Promise<string|undefined> { async getActiveTheme(): Promise<string> {
// check if theme is set via settings // check if theme is set via settings
let theme = await this._platform.settingsStorage.getString("theme"); let theme = await this._platform.settingsStorage.getString("theme");
if (theme) { if (theme) {
@ -70,6 +70,6 @@ export class ThemeLoader {
} else if (window.matchMedia("(prefers-color-scheme: light)").matches) { } else if (window.matchMedia("(prefers-color-scheme: light)").matches) {
return this._platform.config["defaultTheme"].light; return this._platform.config["defaultTheme"].light;
} }
return undefined; throw new Error("Cannot find active theme!");
} }
} }