From 42e5fb33ba9071cc8f0b47e2a335ac40299dbc47 Mon Sep 17 00:00:00 2001
From: Bruno Windels <bruno@windels.cloud>
Date: Wed, 17 Nov 2021 13:50:56 +0100
Subject: [PATCH] remove more non-public methods from ILogItem interface

---
 src/logging/BaseLogger.ts | 8 ++++----
 src/logging/LogItem.ts    | 2 +-
 src/logging/types.ts      | 2 --
 3 files changed, 5 insertions(+), 7 deletions(-)

diff --git a/src/logging/BaseLogger.ts b/src/logging/BaseLogger.ts
index 2f7389ab..7112c948 100644
--- a/src/logging/BaseLogger.ts
+++ b/src/logging/BaseLogger.ts
@@ -21,7 +21,7 @@ import type {ILogger, ILogExport, FilterCreator, LabelOrValues, LogCallback, ILo
 import type {Platform} from "../platform/web/Platform.js";
 
 export abstract class BaseLogger implements ILogger {
-    protected _openItems: Set<ILogItem> = new Set();
+    protected _openItems: Set<LogItem> = new Set();
     protected _platform: Platform;
 
     constructor({platform}) {
@@ -68,10 +68,10 @@ export abstract class BaseLogger implements ILogger {
         return this._run(item, callback, logLevel, true, filterCreator);
     }
 
-    _run<T>(item: ILogItem, callback: LogCallback<T>, logLevel: LogLevel, wantResult: true, filterCreator?: FilterCreator): T;
+    _run<T>(item: LogItem, callback: LogCallback<T>, logLevel: LogLevel, wantResult: true, filterCreator?: FilterCreator): T;
     // we don't return if we don't throw, as we don't have anything to return when an error is caught but swallowed for the fire-and-forget case.
-    _run<T>(item: ILogItem, callback: LogCallback<T>, logLevel: LogLevel, wantResult: false, filterCreator?: FilterCreator): void;
-    _run<T>(item: ILogItem, callback: LogCallback<T>, logLevel: LogLevel, wantResult: boolean, filterCreator?: FilterCreator): T | void {
+    _run<T>(item: LogItem, callback: LogCallback<T>, logLevel: LogLevel, wantResult: false, filterCreator?: FilterCreator): void;
+    _run<T>(item: LogItem, callback: LogCallback<T>, logLevel: LogLevel, wantResult: boolean, filterCreator?: FilterCreator): T | void {
         this._openItems.add(item);
 
         const finishItem = () => {
diff --git a/src/logging/LogItem.ts b/src/logging/LogItem.ts
index 0e5b0ecb..4fb8daa0 100644
--- a/src/logging/LogItem.ts
+++ b/src/logging/LogItem.ts
@@ -233,7 +233,7 @@ export class LogItem implements ILogItem {
         return err;
     }
 
-    child(labelOrValues: LabelOrValues, logLevel?: LogLevel, filterCreator?: FilterCreator): ILogItem {
+    child(labelOrValues: LabelOrValues, logLevel?: LogLevel, filterCreator?: FilterCreator): LogItem {
         if (this.end) {
             console.trace("log item is finished, additional logs will likely not be recorded");
         }
diff --git a/src/logging/types.ts b/src/logging/types.ts
index 280b5606..f90572e5 100644
--- a/src/logging/types.ts
+++ b/src/logging/types.ts
@@ -51,8 +51,6 @@ export interface ILogItem {
     refDetached(logItem: ILogItem, logLevel?: LogLevel): void;
     ensureRefId(): void;
     catch(err: Error): Error;
-    finish(): void;
-    child(labelOrValues: LabelOrValues, logLevel?: LogLevel, filterCreator?: FilterCreator): ILogItem;
     serialize(filter: LogFilter, parentStartTime: number | undefined, forced: boolean): ISerializedItem | undefined;
 }