diff --git a/src/logging/BaseLogger.ts b/src/logging/BaseLogger.ts index 2f7389ab..7112c948 100644 --- a/src/logging/BaseLogger.ts +++ b/src/logging/BaseLogger.ts @@ -21,7 +21,7 @@ import type {ILogger, ILogExport, FilterCreator, LabelOrValues, LogCallback, ILo import type {Platform} from "../platform/web/Platform.js"; export abstract class BaseLogger implements ILogger { - protected _openItems: Set = new Set(); + protected _openItems: Set = new Set(); protected _platform: Platform; constructor({platform}) { @@ -68,10 +68,10 @@ export abstract class BaseLogger implements ILogger { return this._run(item, callback, logLevel, true, filterCreator); } - _run(item: ILogItem, callback: LogCallback, logLevel: LogLevel, wantResult: true, filterCreator?: FilterCreator): T; + _run(item: LogItem, callback: LogCallback, logLevel: LogLevel, wantResult: true, filterCreator?: FilterCreator): T; // we don't return if we don't throw, as we don't have anything to return when an error is caught but swallowed for the fire-and-forget case. - _run(item: ILogItem, callback: LogCallback, logLevel: LogLevel, wantResult: false, filterCreator?: FilterCreator): void; - _run(item: ILogItem, callback: LogCallback, logLevel: LogLevel, wantResult: boolean, filterCreator?: FilterCreator): T | void { + _run(item: LogItem, callback: LogCallback, logLevel: LogLevel, wantResult: false, filterCreator?: FilterCreator): void; + _run(item: LogItem, callback: LogCallback, logLevel: LogLevel, wantResult: boolean, filterCreator?: FilterCreator): T | void { this._openItems.add(item); const finishItem = () => { diff --git a/src/logging/LogItem.ts b/src/logging/LogItem.ts index 0e5b0ecb..4fb8daa0 100644 --- a/src/logging/LogItem.ts +++ b/src/logging/LogItem.ts @@ -233,7 +233,7 @@ export class LogItem implements ILogItem { return err; } - child(labelOrValues: LabelOrValues, logLevel?: LogLevel, filterCreator?: FilterCreator): ILogItem { + child(labelOrValues: LabelOrValues, logLevel?: LogLevel, filterCreator?: FilterCreator): LogItem { if (this.end) { console.trace("log item is finished, additional logs will likely not be recorded"); } diff --git a/src/logging/types.ts b/src/logging/types.ts index 280b5606..f90572e5 100644 --- a/src/logging/types.ts +++ b/src/logging/types.ts @@ -51,8 +51,6 @@ export interface ILogItem { refDetached(logItem: ILogItem, logLevel?: LogLevel): void; ensureRefId(): void; catch(err: Error): Error; - finish(): void; - child(labelOrValues: LabelOrValues, logLevel?: LogLevel, filterCreator?: FilterCreator): ILogItem; serialize(filter: LogFilter, parentStartTime: number | undefined, forced: boolean): ISerializedItem | undefined; }