From 41a7448c7419b0102bac4740b58fa91a5ea52a2f Mon Sep 17 00:00:00 2001
From: Bruno Windels <brunow@matrix.org>
Date: Thu, 27 Aug 2020 10:40:49 +0200
Subject: [PATCH] add logging for room list sorting

---
 .../session/roomlist/RoomTileViewModel.js     | 41 +++++++++++++++----
 1 file changed, 33 insertions(+), 8 deletions(-)

diff --git a/src/domain/session/roomlist/RoomTileViewModel.js b/src/domain/session/roomlist/RoomTileViewModel.js
index ec344f79..25ebf30e 100644
--- a/src/domain/session/roomlist/RoomTileViewModel.js
+++ b/src/domain/session/roomlist/RoomTileViewModel.js
@@ -49,34 +49,59 @@ export class RoomTileViewModel extends ViewModel {
     }
 
     compare(other) {
+        /*
+        put unread rooms first
+        then put rooms with a timestamp first, and sort by name
+        then sort by name for rooms without a timestamp
+         */
         const myRoom = this._room;
         const theirRoom = other._room;
 
+        let buf = "";
+        function log(...args) {
+            buf = buf + args.join(" ") + "\n";
+        }
+        function logResult(result) {
+            if (result === 0) {
+                log("rooms are equal (should not happen)", result);
+            } else if (result > 0) {
+                log(`${theirRoom.name || theirRoom.id} comes first`, result);
+            } else {
+                log(`${myRoom.name || myRoom.id} comes first`, result);
+            }
+            console.log(buf);
+            return result;
+        }
+        log(`comparing ${myRoom.name || theirRoom.id} and ${theirRoom.name || theirRoom.id} ...`);
+        log("comparing isUnread...");
         if (isSortedAsUnread(this) !== isSortedAsUnread(other)) {
             if (isSortedAsUnread(this)) {
-                return -1;
+                return logResult(-1);
             }
-            return 1;
+            return logResult(1);
         }
         const myTimestamp = myRoom.lastMessageTimestamp;
         const theirTimestamp = theirRoom.lastMessageTimestamp;
         // rooms with a timestamp come before rooms without one
         if ((myTimestamp === null) !== (theirTimestamp === null)) {
+            log("checking if either does not have lastMessageTimestamp ...");
             if (theirTimestamp === null) {
-                return -1;
+                return logResult(-1);
             }
-            return 1;
+            return logResult(1);
         }
         const timeDiff = theirTimestamp - myTimestamp;
-        if (timeDiff === 0) {
+        if (timeDiff === 0 || !Number.isSafeInteger(theirTimestamp) || !Number.isSafeInteger(myTimestamp)) {
+            log("checking name ...");
             // sort alphabetically
             const nameCmp = this.name.localeCompare(other.name);
             if (nameCmp === 0) {
-                return this._room.id.localeCompare(other._room.id);
+                return logResult(this._room.id.localeCompare(other._room.id));
             }
-            return nameCmp;
+            return logResult(nameCmp);
         }
-        return timeDiff;
+        log("checking timestamp ...");
+        return logResult(timeDiff);
     }
 
     get isOpen() {