Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Packages Projects Releases Wiki Activity

Add type annotations to BaseObservableList

Browse source
This commit is contained in:
Danila Fedorin 2021-09-29 18:05:30 -07:00
parent 3952c3b969
commit 414280ada9
1 changed files with 15 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
src/observable/list/BaseObservableList.ts
View file

@ -16,7 +16,15 @@ limitations under the License.
import {BaseObservable} from "../BaseObservable";
export class BaseObservableList extends BaseObservable {
export interface IListObserver<T> {
onReset(list: BaseObservableList<T>): void;
onAdd(index: number, value:T, list: BaseObservableList<T>): void;
onUpdate(index: number, value: T, params: any, list: BaseObservableList<T>): void;
onRemove(index: number, value: T, list: BaseObservableList<T>): void
onMove(from: number, to: number, value: T, list: BaseObservableList<T>): void
}
export abstract class BaseObservableList<T> extends BaseObservable<IListObserver<T>> {
emitReset() {
for(let h of this._handlers) {
h.onReset(this);
@ -24,19 +32,19 @@ export class BaseObservableList extends BaseObservable {
}
// we need batch events, mostly on index based collection though?
// maybe we should get started without?
emitAdd(index, value) {
emitAdd(index: number, value: T): void {
for(let h of this._handlers) {
h.onAdd(index, value, this);
}
}
emitUpdate(index, value, params) {
emitUpdate(index: number, value: T, params: any): void {
for(let h of this._handlers) {
h.onUpdate(index, value, params, this);
}
}
emitRemove(index, value) {
emitRemove(index: number, value: T): void {
for(let h of this._handlers) {
h.onRemove(index, value, this);
}
@ -44,17 +52,12 @@ export class BaseObservableList extends BaseObservable {
// toIdx assumes the item has already
// been removed from its fromIdx
emitMove(fromIdx, toIdx, value) {
emitMove(fromIdx: number, toIdx: number, value: T): void {
for(let h of this._handlers) {
h.onMove(fromIdx, toIdx, value, this);
}
}
[Symbol.iterator]() {
throw new Error("unimplemented");
}
get length() {
throw new Error("unimplemented");
}
abstract [Symbol.iterator](): IterableIterator<T>;
abstract get length(): number;
}