From a2ea217245f09178e0ffe7a1b7a448d195ab823f Mon Sep 17 00:00:00 2001
From: Bruno Windels <brunow@matrix.org>
Date: Mon, 31 Aug 2020 16:19:15 +0200
Subject: [PATCH 1/2] early start of code style

---
 codestyle.md | 7 +++++++
 1 file changed, 7 insertions(+)
 create mode 100644 codestyle.md

diff --git a/codestyle.md b/codestyle.md
new file mode 100644
index 00000000..1db6ad0f
--- /dev/null
+++ b/codestyle.md
@@ -0,0 +1,7 @@
+
+# Code-style
+
+ - methods that return a promise should always use async/await
+    otherwise synchronous errors can get swallowed
+ - only named exports, no default exports
+    otherwise it becomes hard to remember what was a default/named export

From cfa011a31707e05b83dc952d5638d0520d9ffb3f Mon Sep 17 00:00:00 2001
From: Bruno Windels <brunow@matrix.org>
Date: Mon, 31 Aug 2020 16:21:12 +0200
Subject: [PATCH 2/2] remove room list sorting logging, works well now

---
 .../session/roomlist/RoomTileViewModel.js     | 39 +++++--------------
 1 file changed, 9 insertions(+), 30 deletions(-)

diff --git a/src/domain/session/roomlist/RoomTileViewModel.js b/src/domain/session/roomlist/RoomTileViewModel.js
index 1882438f..76cab067 100644
--- a/src/domain/session/roomlist/RoomTileViewModel.js
+++ b/src/domain/session/roomlist/RoomTileViewModel.js
@@ -57,35 +57,17 @@ export class RoomTileViewModel extends ViewModel {
         const myRoom = this._room;
         const theirRoom = other._room;
 
-        let buf = "";
-        function log(...args) {
-            buf = buf + args.map(a => a+"").join(" ") + "\n";
-        }
-        function logResult(result) {
-            if (result === 0) {
-                log("rooms are equal (should not happen)", result);
-            } else if (result > 0) {
-                log(`${theirRoom.name || theirRoom.id} comes first`, result);
-            } else {
-                log(`${myRoom.name || myRoom.id} comes first`, result);
-            }
-            console.info(buf);
-            return result;
-        }
-        log(`comparing ${myRoom.name || theirRoom.id} and ${theirRoom.name || theirRoom.id} ...`);
-        log("comparing isLowPriority...");
         if (myRoom.isLowPriority !== theirRoom.isLowPriority) {
             if (myRoom.isLowPriority) {
-                return logResult(1);
+                return 1;
             }
-            return logResult(-1);
+            return -1;
         }
-        log("comparing isUnread...");
         if (isSortedAsUnread(this) !== isSortedAsUnread(other)) {
             if (isSortedAsUnread(this)) {
-                return logResult(-1);
+                return -1;
             }
-            return logResult(1);
+            return 1;
         }
         const myTimestamp = myRoom.lastMessageTimestamp;
         const theirTimestamp = theirRoom.lastMessageTimestamp;
@@ -93,24 +75,21 @@ export class RoomTileViewModel extends ViewModel {
         const theirTimestampValid = Number.isSafeInteger(theirTimestamp);
         // if either does not have a timestamp, put the one with a timestamp first
         if (myTimestampValid !== theirTimestampValid) {
-            log("checking if either does not have lastMessageTimestamp ...", myTimestamp, theirTimestamp);
             if (!theirTimestampValid) {
-                return logResult(-1);
+                return -1;
             }
-            return logResult(1);
+            return 1;
         }
         const timeDiff = theirTimestamp - myTimestamp;
         if (timeDiff === 0 || !theirTimestampValid || !myTimestampValid) {
-            log("checking name ...", myTimestamp, theirTimestamp);
             // sort alphabetically
             const nameCmp = this.name.localeCompare(other.name);
             if (nameCmp === 0) {
-                return logResult(this._room.id.localeCompare(other._room.id));
+                return this._room.id.localeCompare(other._room.id);
             }
-            return logResult(nameCmp);
+            return nameCmp;
         }
-        log("checking timestamp ...");
-        return logResult(timeDiff);
+        return timeDiff;
     }
 
     get isOpen() {