Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

don't throw when container is already disposed, just dispose immediately

Browse source
This commit is contained in:
Bruno Windels 2021-02-22 10:47:17 +01:00
parent 068d25266c
commit 364295c7a9
1 changed files with 5 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/utils/Disposables.js
View file

@ -32,12 +32,14 @@ export class Disposables {
} }
track(disposable) { track(disposable) {
if (this.isDisposed) {
throw new Error("Already disposed, check isDisposed after await if needed");
}
if (!isDisposable(disposable)) { if (!isDisposable(disposable)) {
throw new Error("Not a disposable"); throw new Error("Not a disposable");
} }
if (this.isDisposed) {
console.warn("Disposables already disposed, disposing new value");
disposeValue(disposable);
return disposable;
}
this._disposables.push(disposable); this._disposables.push(disposable);
return disposable; return disposable;
} }