Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

add warning when rendering outside of render fn for templates

Browse source
This commit is contained in:
Bruno Windels 2021-04-15 15:14:02 +02:00
parent 766ce4e217
commit 33f1ba686c
1 changed files with 25 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

34
src/platform/web/ui/general/TemplateView.js
View file

@ -68,12 +68,16 @@ export class TemplateView extends BaseUpdateView {
mount(options) { mount(options) {
const builder = new TemplateBuilder(this); const builder = new TemplateBuilder(this);
if (this._render) { try {
this._root = this._render(builder, this._value); if (this._render) {
} else if (this.render) { // overriden in subclass this._root = this._render(builder, this._value);
this._root = this.render(builder, this._value); } else if (this.render) { // overriden in subclass
} else { this._root = this.render(builder, this._value);
throw new Error("no render function passed in, or overriden in subclass"); } else {
throw new Error("no render function passed in, or overriden in subclass");
}
} finally {
builder.close();
} }
// takes care of update being called when needed // takes care of update being called when needed
super.mount(options); super.mount(options);
@ -145,6 +149,18 @@ export class TemplateView extends BaseUpdateView {
class TemplateBuilder { class TemplateBuilder {
constructor(templateView) { constructor(templateView) {
this._templateView = templateView; this._templateView = templateView;
this._closed = false;
}
close() {
this._closed = true;
}
_addBinding(fn) {
if (this._closed) {
console.trace("Adding a binding after render will likely cause memory leaks");
}
this._templateView._addBinding(fn);
} }
get _value() { get _value() {
@ -164,7 +180,7 @@ class TemplateBuilder {
setAttribute(node, name, newValue); setAttribute(node, name, newValue);
} }
}; };
this._templateView._addBinding(binding); this._addBinding(binding);
binding(); binding();
} }
@ -184,7 +200,7 @@ class TemplateBuilder {
} }
}; };
this._templateView._addBinding(binding); this._addBinding(binding);
return node; return node;
} }
@ -240,7 +256,7 @@ class TemplateBuilder {
node = newNode; node = newNode;
} }
}; };
this._templateView._addBinding(binding); this._addBinding(binding);
return node; return node;
} }