Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

better error handling if something goes wrong serializing log items

Browse source
This commit is contained in:
Bruno Windels 2021-02-16 18:30:23 +01:00
parent 338f628627
commit 2dd8803efc
1 changed files with 14 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/logging/BaseLogger.js
View file

@ -35,9 +35,13 @@ export class BaseLogger {
// if not filter is specified, filter out anything lower than the initial log level // if not filter is specified, filter out anything lower than the initial log level
filter = filter.minLevel(logLevel); filter = filter.minLevel(logLevel);
} }
const serialized = item.serialize(filter, 0); try {
if (serialized) { const serialized = item.serialize(filter, 0);
this._persistItem(serialized); if (serialized) {
this._persistItem(serialized);
}
} catch (err) {
console.warn("Could not serialize log item", err);
} }
this._openItems.delete(item); this._openItems.delete(item);
}; };
@ -65,9 +69,13 @@ export class BaseLogger {
_finishOpenItems() { _finishOpenItems() {
for (const openItem of this._openItems) { for (const openItem of this._openItems) {
openItem.finish(); openItem.finish();
const serialized = openItem.serialize(this._baseLogLevel); try {
if (serialized) { const serialized = openItem.serialize(this._baseLogLevel);
this._persistItem(serialized); if (serialized) {
this._persistItem(serialized);
}
} catch (err) {
console.warn("Could not serialize log item", err);
} }
} }
this._openItems.clear(); this._openItems.clear();