Arsharth/hydrogen-web
1
0
Fork 0
forked from mystiq/hydrogen-web
Code Issues Pull requests Projects Releases Packages Wiki Activity

Make changes

Browse source 
- use textContent where possible
- make sure we have an image before adding title

Signed-off-by: RMidhunSuresh <rmidhunsuresh@gmail.com>
This commit is contained in:
RMidhunSuresh 2021-07-01 19:21:54 +05:30
parent b8c01272f4
commit 191613adbe
1 changed files with 6 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
src/platform/web/ui/AvatarView.js
View file

@ -68,17 +68,19 @@ export class AvatarView extends BaseUpdateView {
this._root.replaceChild(renderImg(vm, this._size), this._root.firstChild); this._root.replaceChild(renderImg(vm, this._size), this._root.firstChild);
this._root.classList.remove(bgColorClass); this._root.classList.remove(bgColorClass);
} else { } else {
this._root.replaceChild(text(vm.avatarLetter), this._root.firstChild); this._root.textContent = vm.avatarLetter;
this._root.classList.add(bgColorClass); this._root.classList.add(bgColorClass);
} }
} }
const hasAvatar = !!vm.avatarUrl(this._size); const hasAvatar = !!vm.avatarUrl(this._size);
if (this._avatarTitleChanged() && hasAvatar) { if (this._avatarTitleChanged() && hasAvatar) {
const img = this._root.firstChild; const element = this._root.firstChild;
img.setAttribute("title", vm.avatarTitle); if (element.tagName === "IMG") {
element.setAttribute("title", vm.avatarTitle);
}
} }
if (this._avatarLetterChanged() && !hasAvatar) { if (this._avatarLetterChanged() && !hasAvatar) {
this._root.firstChild.textContent = vm.avatarLetter; this._root.textContent = vm.avatarLetter;
} }
} }
} }