Merge pull request #503 from vector-im/bwindels/fix-reactions-vm-null

use mapped value rather than reading parent vm again
This commit is contained in:
Bruno Windels 2021-09-21 10:09:05 +02:00 committed by GitHub
commit 07c6bf7055
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -66,7 +66,7 @@ export class BaseMessageView extends TemplateView {
let reactionsView = null; let reactionsView = null;
t.mapSideEffect(vm => vm.reactions, reactions => { t.mapSideEffect(vm => vm.reactions, reactions => {
if (reactions && this._interactive && !reactionsView) { if (reactions && this._interactive && !reactionsView) {
reactionsView = new ReactionsView(vm.reactions); reactionsView = new ReactionsView(reactions);
this.addSubView(reactionsView); this.addSubView(reactionsView);
li.appendChild(mountView(reactionsView)); li.appendChild(mountView(reactionsView));
} else if (!reactions && reactionsView) { } else if (!reactions && reactionsView) {