forked from mystiq/dex
b572b8dd6c
The DB implementation expects secrets to be base64 encoded blobs. Because of this a bunch of tests broke moving to sqlite. A lot of this commit is fixing those tests.
833 lines
22 KiB
Go
833 lines
22 KiB
Go
package server
|
|
|
|
import (
|
|
"encoding/base64"
|
|
"errors"
|
|
"fmt"
|
|
"net/url"
|
|
"reflect"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/coreos/dex/client"
|
|
"github.com/coreos/dex/db"
|
|
"github.com/coreos/dex/refresh/refreshtest"
|
|
"github.com/coreos/dex/session/manager"
|
|
"github.com/coreos/dex/user"
|
|
"github.com/coreos/go-oidc/jose"
|
|
"github.com/coreos/go-oidc/key"
|
|
"github.com/coreos/go-oidc/oauth2"
|
|
"github.com/coreos/go-oidc/oidc"
|
|
"github.com/kylelemons/godebug/pretty"
|
|
)
|
|
|
|
var clientTestSecret = base64.URLEncoding.EncodeToString([]byte("secrete"))
|
|
|
|
type StaticKeyManager struct {
|
|
key.PrivateKeyManager
|
|
expiresAt time.Time
|
|
signer jose.Signer
|
|
keys []jose.JWK
|
|
}
|
|
|
|
func (m *StaticKeyManager) ExpiresAt() time.Time {
|
|
return m.expiresAt
|
|
}
|
|
|
|
func (m *StaticKeyManager) Signer() (jose.Signer, error) {
|
|
return m.signer, nil
|
|
}
|
|
|
|
func (m *StaticKeyManager) JWKs() ([]jose.JWK, error) {
|
|
return m.keys, nil
|
|
}
|
|
|
|
type StaticSigner struct {
|
|
sig []byte
|
|
err error
|
|
}
|
|
|
|
func (ss *StaticSigner) ID() string {
|
|
return "static"
|
|
}
|
|
|
|
func (ss *StaticSigner) Alg() string {
|
|
return "static"
|
|
}
|
|
|
|
func (ss *StaticSigner) Verify(sig, data []byte) error {
|
|
if !reflect.DeepEqual(ss.sig, sig) {
|
|
return errors.New("signature mismatch")
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
func (ss *StaticSigner) Sign(data []byte) ([]byte, error) {
|
|
return ss.sig, ss.err
|
|
}
|
|
|
|
func (ss *StaticSigner) JWK() jose.JWK {
|
|
return jose.JWK{}
|
|
}
|
|
|
|
func staticGenerateCodeFunc(code string) manager.GenerateCodeFunc {
|
|
return func() (string, error) {
|
|
return code, nil
|
|
}
|
|
}
|
|
|
|
func makeNewUserRepo() (user.UserRepo, error) {
|
|
userRepo := db.NewUserRepo(db.NewMemDB())
|
|
|
|
id := "testid-1"
|
|
err := userRepo.Create(nil, user.User{
|
|
ID: id,
|
|
Email: "testname@example.com",
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = userRepo.AddRemoteIdentity(nil, id, user.RemoteIdentity{
|
|
ConnectorID: "test_connector_id",
|
|
ID: "YYY",
|
|
})
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
return userRepo, nil
|
|
}
|
|
|
|
func TestServerProviderConfig(t *testing.T) {
|
|
srv := &Server{IssuerURL: url.URL{Scheme: "http", Host: "server.example.com"}}
|
|
|
|
want := oidc.ProviderConfig{
|
|
Issuer: &url.URL{Scheme: "http", Host: "server.example.com"},
|
|
AuthEndpoint: &url.URL{Scheme: "http", Host: "server.example.com", Path: "/auth"},
|
|
TokenEndpoint: &url.URL{Scheme: "http", Host: "server.example.com", Path: "/token"},
|
|
KeysEndpoint: &url.URL{Scheme: "http", Host: "server.example.com", Path: "/keys"},
|
|
|
|
GrantTypesSupported: []string{oauth2.GrantTypeAuthCode, oauth2.GrantTypeClientCreds},
|
|
ResponseTypesSupported: []string{"code"},
|
|
SubjectTypesSupported: []string{"public"},
|
|
IDTokenSigningAlgValues: []string{"RS256"},
|
|
TokenEndpointAuthMethodsSupported: []string{"client_secret_basic"},
|
|
}
|
|
got := srv.ProviderConfig()
|
|
|
|
if diff := pretty.Compare(want, got); diff != "" {
|
|
t.Fatalf("provider config did not match expected: %s", diff)
|
|
}
|
|
}
|
|
|
|
func TestServerNewSession(t *testing.T) {
|
|
sm := manager.NewSessionManager(db.NewSessionRepo(db.NewMemDB()), db.NewSessionKeyRepo(db.NewMemDB()))
|
|
srv := &Server{
|
|
SessionManager: sm,
|
|
}
|
|
|
|
state := "pants"
|
|
nonce := "oncenay"
|
|
ci := oidc.ClientIdentity{
|
|
Credentials: oidc.ClientCredentials{
|
|
ID: "XXX",
|
|
Secret: "secrete",
|
|
},
|
|
Metadata: oidc.ClientMetadata{
|
|
RedirectURIs: []url.URL{
|
|
url.URL{
|
|
Scheme: "http",
|
|
Host: "client.example.com",
|
|
Path: "/callback",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
|
|
key, err := srv.NewSession("bogus_idpc", ci.Credentials.ID, state, ci.Metadata.RedirectURIs[0], nonce, false, []string{"openid"})
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
sessionID, err := sm.ExchangeKey(key)
|
|
if err != nil {
|
|
t.Fatalf("Session not retreivable: %v", err)
|
|
}
|
|
|
|
ses, err := sm.AttachRemoteIdentity(sessionID, oidc.Identity{})
|
|
if err != nil {
|
|
t.Fatalf("Unable to add Identity to Session: %v", err)
|
|
}
|
|
|
|
if !reflect.DeepEqual(ci.Metadata.RedirectURIs[0], ses.RedirectURL) {
|
|
t.Fatalf("Session created with incorrect RedirectURL: want=%#v got=%#v", ci.Metadata.RedirectURIs[0], ses.RedirectURL)
|
|
}
|
|
|
|
if ci.Credentials.ID != ses.ClientID {
|
|
t.Fatalf("Session created with incorrect ClientID: want=%q got=%q", ci.Credentials.ID, ses.ClientID)
|
|
}
|
|
|
|
if state != ses.ClientState {
|
|
t.Fatalf("Session created with incorrect State: want=%q got=%q", state, ses.ClientState)
|
|
}
|
|
|
|
if nonce != ses.Nonce {
|
|
t.Fatalf("Session created with incorrect Nonce: want=%q got=%q", nonce, ses.Nonce)
|
|
}
|
|
}
|
|
|
|
func TestServerLogin(t *testing.T) {
|
|
ci := oidc.ClientIdentity{
|
|
Credentials: oidc.ClientCredentials{
|
|
ID: "XXX",
|
|
Secret: clientTestSecret,
|
|
},
|
|
Metadata: oidc.ClientMetadata{
|
|
RedirectURIs: []url.URL{
|
|
url.URL{
|
|
Scheme: "http",
|
|
Host: "client.example.com",
|
|
Path: "/callback",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
ciRepo := func() client.ClientIdentityRepo {
|
|
repo, err := db.NewClientIdentityRepoFromClients(db.NewMemDB(), []oidc.ClientIdentity{ci})
|
|
if err != nil {
|
|
t.Fatalf("Failed to create client identity repo: %v", err)
|
|
}
|
|
return repo
|
|
}()
|
|
|
|
km := &StaticKeyManager{
|
|
signer: &StaticSigner{sig: []byte("beer"), err: nil},
|
|
}
|
|
|
|
sm := manager.NewSessionManager(db.NewSessionRepo(db.NewMemDB()), db.NewSessionKeyRepo(db.NewMemDB()))
|
|
sm.GenerateCode = staticGenerateCodeFunc("fakecode")
|
|
sessionID, err := sm.NewSession("test_connector_id", ci.Credentials.ID, "bogus", ci.Metadata.RedirectURIs[0], "", false, []string{"openid"})
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
userRepo, err := makeNewUserRepo()
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
srv := &Server{
|
|
IssuerURL: url.URL{Scheme: "http", Host: "server.example.com"},
|
|
KeyManager: km,
|
|
SessionManager: sm,
|
|
ClientIdentityRepo: ciRepo,
|
|
UserRepo: userRepo,
|
|
}
|
|
|
|
ident := oidc.Identity{ID: "YYY", Name: "elroy", Email: "elroy@example.com"}
|
|
key, err := sm.NewSessionKey(sessionID)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
redirectURL, err := srv.Login(ident, key)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected err from Server.Login: %v", err)
|
|
}
|
|
|
|
wantRedirectURL := "http://client.example.com/callback?code=fakecode&state=bogus"
|
|
if wantRedirectURL != redirectURL {
|
|
t.Fatalf("Unexpected redirectURL: want=%q, got=%q", wantRedirectURL, redirectURL)
|
|
}
|
|
}
|
|
|
|
func TestServerLoginUnrecognizedSessionKey(t *testing.T) {
|
|
ciRepo := func() client.ClientIdentityRepo {
|
|
repo, err := db.NewClientIdentityRepoFromClients(db.NewMemDB(), []oidc.ClientIdentity{
|
|
oidc.ClientIdentity{
|
|
Credentials: oidc.ClientCredentials{
|
|
ID: "XXX", Secret: clientTestSecret,
|
|
},
|
|
},
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("Failed to create client identity repo: %v", err)
|
|
}
|
|
return repo
|
|
}()
|
|
|
|
km := &StaticKeyManager{
|
|
signer: &StaticSigner{sig: nil, err: errors.New("fail")},
|
|
}
|
|
sm := manager.NewSessionManager(db.NewSessionRepo(db.NewMemDB()), db.NewSessionKeyRepo(db.NewMemDB()))
|
|
srv := &Server{
|
|
IssuerURL: url.URL{Scheme: "http", Host: "server.example.com"},
|
|
KeyManager: km,
|
|
SessionManager: sm,
|
|
ClientIdentityRepo: ciRepo,
|
|
}
|
|
|
|
ident := oidc.Identity{ID: "YYY", Name: "elroy", Email: "elroy@example.com"}
|
|
code, err := srv.Login(ident, "XXX")
|
|
if err == nil {
|
|
t.Fatalf("Expected non-nil error")
|
|
}
|
|
|
|
if code != "" {
|
|
t.Fatalf("Expected empty code, got=%s", code)
|
|
}
|
|
}
|
|
|
|
func TestServerLoginDisabledUser(t *testing.T) {
|
|
ci := oidc.ClientIdentity{
|
|
Credentials: oidc.ClientCredentials{
|
|
ID: "XXX",
|
|
Secret: clientTestSecret,
|
|
},
|
|
Metadata: oidc.ClientMetadata{
|
|
RedirectURIs: []url.URL{
|
|
url.URL{
|
|
Scheme: "http",
|
|
Host: "client.example.com",
|
|
Path: "/callback",
|
|
},
|
|
},
|
|
},
|
|
}
|
|
ciRepo := func() client.ClientIdentityRepo {
|
|
repo, err := db.NewClientIdentityRepoFromClients(db.NewMemDB(), []oidc.ClientIdentity{ci})
|
|
if err != nil {
|
|
t.Fatalf("Failed to create client identity repo: %v", err)
|
|
}
|
|
return repo
|
|
}()
|
|
|
|
km := &StaticKeyManager{
|
|
signer: &StaticSigner{sig: []byte("beer"), err: nil},
|
|
}
|
|
|
|
sm := manager.NewSessionManager(db.NewSessionRepo(db.NewMemDB()), db.NewSessionKeyRepo(db.NewMemDB()))
|
|
sm.GenerateCode = staticGenerateCodeFunc("fakecode")
|
|
sessionID, err := sm.NewSession("test_connector_id", ci.Credentials.ID, "bogus", ci.Metadata.RedirectURIs[0], "", false, []string{"openid"})
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
userRepo, err := makeNewUserRepo()
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
err = userRepo.Create(nil, user.User{
|
|
ID: "disabled-1",
|
|
Email: "disabled@example.com",
|
|
Disabled: true,
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
err = userRepo.AddRemoteIdentity(nil, "disabled-1", user.RemoteIdentity{
|
|
ConnectorID: "test_connector_id",
|
|
ID: "disabled-connector-id",
|
|
})
|
|
|
|
srv := &Server{
|
|
IssuerURL: url.URL{Scheme: "http", Host: "server.example.com"},
|
|
KeyManager: km,
|
|
SessionManager: sm,
|
|
ClientIdentityRepo: ciRepo,
|
|
UserRepo: userRepo,
|
|
}
|
|
|
|
ident := oidc.Identity{ID: "disabled-connector-id", Name: "elroy", Email: "elroy@example.com"}
|
|
key, err := sm.NewSessionKey(sessionID)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
_, err = srv.Login(ident, key)
|
|
if err == nil {
|
|
t.Errorf("disabled user was allowed to log in")
|
|
}
|
|
}
|
|
|
|
func TestServerCodeToken(t *testing.T) {
|
|
ci := oidc.ClientIdentity{
|
|
Credentials: oidc.ClientCredentials{
|
|
ID: "XXX",
|
|
Secret: clientTestSecret,
|
|
},
|
|
}
|
|
ciRepo := func() client.ClientIdentityRepo {
|
|
repo, err := db.NewClientIdentityRepoFromClients(db.NewMemDB(), []oidc.ClientIdentity{ci})
|
|
if err != nil {
|
|
t.Fatalf("Failed to create client identity repo: %v", err)
|
|
}
|
|
return repo
|
|
}()
|
|
km := &StaticKeyManager{
|
|
signer: &StaticSigner{sig: []byte("beer"), err: nil},
|
|
}
|
|
sm := manager.NewSessionManager(db.NewSessionRepo(db.NewMemDB()), db.NewSessionKeyRepo(db.NewMemDB()))
|
|
|
|
userRepo, err := makeNewUserRepo()
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
refreshTokenRepo := refreshtest.NewTestRefreshTokenRepo()
|
|
|
|
srv := &Server{
|
|
IssuerURL: url.URL{Scheme: "http", Host: "server.example.com"},
|
|
KeyManager: km,
|
|
SessionManager: sm,
|
|
ClientIdentityRepo: ciRepo,
|
|
UserRepo: userRepo,
|
|
RefreshTokenRepo: refreshTokenRepo,
|
|
}
|
|
|
|
tests := []struct {
|
|
scope []string
|
|
refreshToken string
|
|
}{
|
|
// No 'offline_access' in scope, should get empty refresh token.
|
|
{
|
|
scope: []string{"openid"},
|
|
refreshToken: "",
|
|
},
|
|
// Have 'offline_access' in scope, should get non-empty refresh token.
|
|
{
|
|
// NOTE(ericchiang): This test assumes that the database ID of the first
|
|
// refresh token will be "1".
|
|
scope: []string{"openid", "offline_access"},
|
|
refreshToken: fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
},
|
|
}
|
|
|
|
for i, tt := range tests {
|
|
sessionID, err := sm.NewSession("bogus_idpc", ci.Credentials.ID, "bogus", url.URL{}, "", false, tt.scope)
|
|
if err != nil {
|
|
t.Fatalf("case %d: unexpected error: %v", i, err)
|
|
}
|
|
_, err = sm.AttachRemoteIdentity(sessionID, oidc.Identity{})
|
|
if err != nil {
|
|
t.Fatalf("case %d: unexpected error: %v", i, err)
|
|
}
|
|
|
|
_, err = sm.AttachUser(sessionID, "testid-1")
|
|
if err != nil {
|
|
t.Fatalf("case %d: unexpected error: %v", i, err)
|
|
}
|
|
|
|
key, err := sm.NewSessionKey(sessionID)
|
|
if err != nil {
|
|
t.Fatalf("case %d: unexpected error: %v", i, err)
|
|
}
|
|
|
|
jwt, token, err := srv.CodeToken(ci.Credentials, key)
|
|
if err != nil {
|
|
t.Fatalf("case %d: unexpected error: %v", i, err)
|
|
}
|
|
if jwt == nil {
|
|
t.Fatalf("case %d: expect non-nil jwt", i)
|
|
}
|
|
if token != tt.refreshToken {
|
|
t.Fatalf("case %d: expect refresh token %q, got %q", i, tt.refreshToken, token)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestServerTokenUnrecognizedKey(t *testing.T) {
|
|
ci := oidc.ClientIdentity{
|
|
Credentials: oidc.ClientCredentials{
|
|
ID: "XXX",
|
|
Secret: clientTestSecret,
|
|
},
|
|
}
|
|
ciRepo := func() client.ClientIdentityRepo {
|
|
repo, err := db.NewClientIdentityRepoFromClients(db.NewMemDB(), []oidc.ClientIdentity{ci})
|
|
if err != nil {
|
|
t.Fatalf("Failed to create client identity repo: %v", err)
|
|
}
|
|
return repo
|
|
}()
|
|
km := &StaticKeyManager{
|
|
signer: &StaticSigner{sig: []byte("beer"), err: nil},
|
|
}
|
|
sm := manager.NewSessionManager(db.NewSessionRepo(db.NewMemDB()), db.NewSessionKeyRepo(db.NewMemDB()))
|
|
|
|
srv := &Server{
|
|
IssuerURL: url.URL{Scheme: "http", Host: "server.example.com"},
|
|
KeyManager: km,
|
|
SessionManager: sm,
|
|
ClientIdentityRepo: ciRepo,
|
|
}
|
|
|
|
sessionID, err := sm.NewSession("connector_id", ci.Credentials.ID, "bogus", url.URL{}, "", false, []string{"openid", "offline_access"})
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
_, err = sm.AttachRemoteIdentity(sessionID, oidc.Identity{})
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
jwt, token, err := srv.CodeToken(ci.Credentials, "foo")
|
|
if err == nil {
|
|
t.Fatalf("Expected non-nil error")
|
|
}
|
|
if jwt != nil {
|
|
t.Fatalf("Expected nil jwt")
|
|
}
|
|
if token != "" {
|
|
t.Fatalf("Expected empty refresh token")
|
|
}
|
|
}
|
|
|
|
func TestServerTokenFail(t *testing.T) {
|
|
issuerURL := url.URL{Scheme: "http", Host: "server.example.com"}
|
|
keyFixture := "goodkey"
|
|
ccFixture := oidc.ClientCredentials{
|
|
ID: "XXX",
|
|
Secret: clientTestSecret,
|
|
}
|
|
signerFixture := &StaticSigner{sig: []byte("beer"), err: nil}
|
|
|
|
tests := []struct {
|
|
signer jose.Signer
|
|
argCC oidc.ClientCredentials
|
|
argKey string
|
|
err error
|
|
scope []string
|
|
refreshToken string
|
|
}{
|
|
// control test case to make sure fixtures check out
|
|
{
|
|
// NOTE(ericchiang): This test assumes that the database ID of the first
|
|
// refresh token will be "1".
|
|
signer: signerFixture,
|
|
argCC: ccFixture,
|
|
argKey: keyFixture,
|
|
scope: []string{"openid", "offline_access"},
|
|
refreshToken: fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
},
|
|
|
|
// no 'offline_access' in 'scope', should get empty refresh token
|
|
{
|
|
signer: signerFixture,
|
|
argCC: ccFixture,
|
|
argKey: keyFixture,
|
|
scope: []string{"openid"},
|
|
},
|
|
|
|
// unrecognized key
|
|
{
|
|
signer: signerFixture,
|
|
argCC: ccFixture,
|
|
argKey: "foo",
|
|
err: oauth2.NewError(oauth2.ErrorInvalidGrant),
|
|
scope: []string{"openid", "offline_access"},
|
|
},
|
|
|
|
// unrecognized client
|
|
{
|
|
signer: signerFixture,
|
|
argCC: oidc.ClientCredentials{ID: "YYY"},
|
|
argKey: keyFixture,
|
|
err: oauth2.NewError(oauth2.ErrorInvalidClient),
|
|
scope: []string{"openid", "offline_access"},
|
|
},
|
|
|
|
// signing operation fails
|
|
{
|
|
signer: &StaticSigner{sig: nil, err: errors.New("fail")},
|
|
argCC: ccFixture,
|
|
argKey: keyFixture,
|
|
err: oauth2.NewError(oauth2.ErrorServerError),
|
|
scope: []string{"openid", "offline_access"},
|
|
},
|
|
}
|
|
|
|
for i, tt := range tests {
|
|
sm := manager.NewSessionManager(db.NewSessionRepo(db.NewMemDB()), db.NewSessionKeyRepo(db.NewMemDB()))
|
|
sm.GenerateCode = func() (string, error) { return keyFixture, nil }
|
|
|
|
sessionID, err := sm.NewSession("connector_id", ccFixture.ID, "bogus", url.URL{}, "", false, tt.scope)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
_, err = sm.AttachRemoteIdentity(sessionID, oidc.Identity{})
|
|
if err != nil {
|
|
t.Errorf("case %d: unexpected error: %v", i, err)
|
|
continue
|
|
}
|
|
km := &StaticKeyManager{
|
|
signer: tt.signer,
|
|
}
|
|
ciRepo, err := db.NewClientIdentityRepoFromClients(db.NewMemDB(), []oidc.ClientIdentity{
|
|
oidc.ClientIdentity{Credentials: ccFixture},
|
|
})
|
|
if err != nil {
|
|
t.Errorf("case %d: failed to create client identity repo: %v", i, err)
|
|
continue
|
|
}
|
|
|
|
_, err = sm.AttachUser(sessionID, "testid-1")
|
|
if err != nil {
|
|
t.Fatalf("case %d: unexpected error: %v", i, err)
|
|
}
|
|
|
|
userRepo, err := makeNewUserRepo()
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
refreshTokenRepo := refreshtest.NewTestRefreshTokenRepo()
|
|
|
|
srv := &Server{
|
|
IssuerURL: issuerURL,
|
|
KeyManager: km,
|
|
SessionManager: sm,
|
|
ClientIdentityRepo: ciRepo,
|
|
UserRepo: userRepo,
|
|
RefreshTokenRepo: refreshTokenRepo,
|
|
}
|
|
|
|
_, err = sm.NewSessionKey(sessionID)
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
jwt, token, err := srv.CodeToken(tt.argCC, tt.argKey)
|
|
if token != tt.refreshToken {
|
|
fmt.Printf("case %d: expect refresh token %q, got %q\n", i, tt.refreshToken, token)
|
|
t.Fatalf("case %d: expect refresh token %q, got %q", i, tt.refreshToken, token)
|
|
panic("")
|
|
}
|
|
if !reflect.DeepEqual(err, tt.err) {
|
|
t.Errorf("case %d: expect %v, got %v", i, tt.err, err)
|
|
}
|
|
if err == nil && jwt == nil {
|
|
t.Errorf("case %d: got nil JWT", i)
|
|
}
|
|
if err != nil && jwt != nil {
|
|
t.Errorf("case %d: got non-nil JWT %v", i, jwt)
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestServerRefreshToken(t *testing.T) {
|
|
issuerURL := url.URL{Scheme: "http", Host: "server.example.com"}
|
|
|
|
credXXX := oidc.ClientCredentials{
|
|
ID: "XXX",
|
|
Secret: clientTestSecret,
|
|
}
|
|
credYYY := oidc.ClientCredentials{
|
|
ID: "YYY",
|
|
Secret: clientTestSecret,
|
|
}
|
|
|
|
signerFixture := &StaticSigner{sig: []byte("beer"), err: nil}
|
|
|
|
// NOTE(ericchiang): These tests assume that the database ID of the first
|
|
// refresh token will be "1".
|
|
tests := []struct {
|
|
token string
|
|
clientID string // The client that associates with the token.
|
|
creds oidc.ClientCredentials
|
|
signer jose.Signer
|
|
err error
|
|
}{
|
|
// Everything is good.
|
|
{
|
|
fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
"XXX",
|
|
credXXX,
|
|
signerFixture,
|
|
nil,
|
|
},
|
|
// Invalid refresh token(malformatted).
|
|
{
|
|
"invalid-token",
|
|
"XXX",
|
|
credXXX,
|
|
signerFixture,
|
|
oauth2.NewError(oauth2.ErrorInvalidRequest),
|
|
},
|
|
// Invalid refresh token(invalid payload content).
|
|
{
|
|
fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-2"))),
|
|
"XXX",
|
|
credXXX,
|
|
signerFixture,
|
|
oauth2.NewError(oauth2.ErrorInvalidRequest),
|
|
},
|
|
// Invalid refresh token(invalid ID content).
|
|
{
|
|
fmt.Sprintf("0/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
"XXX",
|
|
credXXX,
|
|
signerFixture,
|
|
oauth2.NewError(oauth2.ErrorInvalidRequest),
|
|
},
|
|
// Invalid client(client is not associated with the token).
|
|
{
|
|
fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
"XXX",
|
|
credYYY,
|
|
signerFixture,
|
|
oauth2.NewError(oauth2.ErrorInvalidClient),
|
|
},
|
|
// Invalid client(no client ID).
|
|
{
|
|
fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
"XXX",
|
|
oidc.ClientCredentials{ID: "", Secret: "aaa"},
|
|
signerFixture,
|
|
oauth2.NewError(oauth2.ErrorInvalidClient),
|
|
},
|
|
// Invalid client(no such client).
|
|
{
|
|
fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
"XXX",
|
|
oidc.ClientCredentials{ID: "AAA", Secret: "aaa"},
|
|
signerFixture,
|
|
oauth2.NewError(oauth2.ErrorInvalidClient),
|
|
},
|
|
// Invalid client(no secrets).
|
|
{
|
|
fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
"XXX",
|
|
oidc.ClientCredentials{ID: "XXX"},
|
|
signerFixture,
|
|
oauth2.NewError(oauth2.ErrorInvalidClient),
|
|
},
|
|
// Invalid client(invalid secret).
|
|
{
|
|
fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
"XXX",
|
|
oidc.ClientCredentials{ID: "XXX", Secret: "bad-secret"},
|
|
signerFixture,
|
|
oauth2.NewError(oauth2.ErrorInvalidClient),
|
|
},
|
|
// Signing operation fails.
|
|
{
|
|
fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))),
|
|
"XXX",
|
|
credXXX,
|
|
&StaticSigner{sig: nil, err: errors.New("fail")},
|
|
oauth2.NewError(oauth2.ErrorServerError),
|
|
},
|
|
}
|
|
|
|
for i, tt := range tests {
|
|
km := &StaticKeyManager{
|
|
signer: tt.signer,
|
|
}
|
|
|
|
ciRepo, err := db.NewClientIdentityRepoFromClients(db.NewMemDB(), []oidc.ClientIdentity{
|
|
oidc.ClientIdentity{Credentials: credXXX},
|
|
oidc.ClientIdentity{Credentials: credYYY},
|
|
})
|
|
if err != nil {
|
|
t.Errorf("case %d: failed to create client identity repo: %v", i, err)
|
|
continue
|
|
}
|
|
|
|
userRepo, err := makeNewUserRepo()
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
refreshTokenRepo := refreshtest.NewTestRefreshTokenRepo()
|
|
|
|
srv := &Server{
|
|
IssuerURL: issuerURL,
|
|
KeyManager: km,
|
|
ClientIdentityRepo: ciRepo,
|
|
UserRepo: userRepo,
|
|
RefreshTokenRepo: refreshTokenRepo,
|
|
}
|
|
|
|
if _, err := refreshTokenRepo.Create("testid-1", tt.clientID); err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
jwt, err := srv.RefreshToken(tt.creds, tt.token)
|
|
if !reflect.DeepEqual(err, tt.err) {
|
|
t.Errorf("Case %d: expect: %v, got: %v", i, tt.err, err)
|
|
}
|
|
|
|
if jwt != nil {
|
|
if string(jwt.Signature) != "beer" {
|
|
t.Errorf("Case %d: expect signature: beer, got signature: %v", i, jwt.Signature)
|
|
}
|
|
claims, err := jwt.Claims()
|
|
if err != nil {
|
|
t.Errorf("Case %d: unexpected error: %v", i, err)
|
|
}
|
|
if claims["iss"] != issuerURL.String() || claims["sub"] != "testid-1" || claims["aud"] != "XXX" {
|
|
t.Errorf("Case %d: invalid claims: %v", i, claims)
|
|
}
|
|
}
|
|
}
|
|
|
|
// Test that we should return error when user cannot be found after
|
|
// verifying the token.
|
|
km := &StaticKeyManager{
|
|
signer: signerFixture,
|
|
}
|
|
|
|
ciRepo, err := db.NewClientIdentityRepoFromClients(db.NewMemDB(), []oidc.ClientIdentity{
|
|
oidc.ClientIdentity{Credentials: credXXX},
|
|
oidc.ClientIdentity{Credentials: credYYY},
|
|
})
|
|
if err != nil {
|
|
t.Fatalf("failed to create client identity repo: %v", err)
|
|
}
|
|
|
|
userRepo, err := makeNewUserRepo()
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
// Create a user that will be removed later.
|
|
if err := userRepo.Create(nil, user.User{
|
|
ID: "testid-2",
|
|
Email: "test-2@example.com",
|
|
}); err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
refreshTokenRepo := refreshtest.NewTestRefreshTokenRepo()
|
|
|
|
srv := &Server{
|
|
IssuerURL: issuerURL,
|
|
KeyManager: km,
|
|
ClientIdentityRepo: ciRepo,
|
|
UserRepo: userRepo,
|
|
RefreshTokenRepo: refreshTokenRepo,
|
|
}
|
|
|
|
if _, err := refreshTokenRepo.Create("testid-2", credXXX.ID); err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
|
|
// Recreate the user repo to remove the user we created.
|
|
userRepo, err = makeNewUserRepo()
|
|
if err != nil {
|
|
t.Fatalf("Unexpected error: %v", err)
|
|
}
|
|
srv.UserRepo = userRepo
|
|
|
|
_, err = srv.RefreshToken(credXXX, fmt.Sprintf("1/%s", base64.URLEncoding.EncodeToString([]byte("refresh-1"))))
|
|
if !reflect.DeepEqual(err, oauth2.NewError(oauth2.ErrorServerError)) {
|
|
t.Errorf("Expect: %v, got: %v", oauth2.NewError(oauth2.ErrorServerError), err)
|
|
}
|
|
}
|