Merge pull request #190 from ericchiang/valid_email

user: fix bug in ValidEmail helper
This commit is contained in:
bobbyrullo 2015-12-01 15:06:42 -05:00
commit a1b7f9e709
2 changed files with 6 additions and 4 deletions

View file

@ -163,10 +163,9 @@ func ValidEmail(email string) bool {
return false return false
} }
if address.Name != "" || address.Address == "" { // Has mail.ParseAddress parsed the entire string and only found a single
return false // address without a name?
} return address.Address == email
return true
} }
func ValidPassword(plaintext string) bool { func ValidPassword(plaintext string) bool {

View file

@ -103,6 +103,9 @@ func TestValidEmail(t *testing.T) {
{"r@r.com", true}, {"r@r.com", true},
{"Barry Gibbs <bg@example.com>", false}, {"Barry Gibbs <bg@example.com>", false},
{"", false}, {"", false},
{"invalidemail", false},
{"example@example.com example@example.com", false},
{"example@example.com Hello, 世界", false},
} }
for i, tt := range tests { for i, tt := range tests {