Arsharth/dex
1
0
Fork 0
forked from mystiq/dex
Code Issues Pull requests Projects Releases Packages Wiki Activity

db: add better comment about migration

Browse source
This commit is contained in:
Eric Chiang 2016-03-02 14:47:00 -08:00
parent 01a24542e9
commit 4feaae98b0
2 changed files with 5 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
db/migrations/0011_case_insensitive_emails.sql
View file

@ -1,5 +1,9 @@
-- +migrate Up -- +migrate Up
-- This migration is a fix for a bug that allowed duplicate emails if they used different cases (see #338).
-- When migrating, dex will not take the liberty of deleting rows for duplicate cases. Instead it will
-- raise an exception and call for an admin to remove duplicates manually.
CREATE OR REPLACE FUNCTION raise_exp() RETURNS VOID AS $$ CREATE OR REPLACE FUNCTION raise_exp() RETURNS VOID AS $$
BEGIN BEGIN
RAISE EXCEPTION 'Found duplicate emails when using case insensitive comparision, cannot perform migration.'; RAISE EXCEPTION 'Found duplicate emails when using case insensitive comparision, cannot perform migration.';

2
db/user.go
View file

@ -425,7 +425,7 @@ func (r *userRepo) insertRemoteIdentity(tx repo.Transaction, userID string, ri u
type userModel struct { type userModel struct {
ID string `db:"id"` ID string `db:"id"`
Email string `db:"email"` // NOTE(ericchiang): When making comparisions emails are case insensitive. Email string `db:"email"`
EmailVerified bool `db:"email_verified"` EmailVerified bool `db:"email_verified"`
DisplayName string `db:"display_name"` DisplayName string `db:"display_name"`
Disabled bool `db:"disabled"` Disabled bool `db:"disabled"`