grpc-client: Do not crash on empty response (#2584)

Signed-off-by: Björn Busse <bj.rn@baerlin.eu>
This commit is contained in:
Björn Busse 2022-07-25 21:30:22 +02:00 committed by GitHub
parent 27c25d00be
commit 4a0218e87c
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23

View file

@ -58,7 +58,7 @@ func createPassword(cli api.DexClient) error {
// Create password. // Create password.
if resp, err := cli.CreatePassword(context.TODO(), createReq); err != nil || resp.AlreadyExists { if resp, err := cli.CreatePassword(context.TODO(), createReq); err != nil || resp.AlreadyExists {
if resp.AlreadyExists { if resp != nil && resp.AlreadyExists {
return fmt.Errorf("Password %s already exists", createReq.Password.Email) return fmt.Errorf("Password %s already exists", createReq.Password.Email)
} }
return fmt.Errorf("failed to create password: %v", err) return fmt.Errorf("failed to create password: %v", err)
@ -115,7 +115,7 @@ func createPassword(cli api.DexClient) error {
// Delete password with email = test@example.com. // Delete password with email = test@example.com.
if resp, err := cli.DeletePassword(context.TODO(), deleteReq); err != nil || resp.NotFound { if resp, err := cli.DeletePassword(context.TODO(), deleteReq); err != nil || resp.NotFound {
if resp.NotFound { if resp != nil && resp.NotFound {
return fmt.Errorf("Password %s not found", deleteReq.Email) return fmt.Errorf("Password %s not found", deleteReq.Email)
} }
return fmt.Errorf("failed to delete password: %v", err) return fmt.Errorf("failed to delete password: %v", err)