From 449f34ed2a35317cbbc531960fb72e8b086ac9ef Mon Sep 17 00:00:00 2001 From: Eric Chiang Date: Wed, 12 Oct 2016 21:56:47 -0700 Subject: [PATCH] storage/sql: print error before calling t.Fatal --- storage/sql/config_test.go | 15 ++++++++++----- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/storage/sql/config_test.go b/storage/sql/config_test.go index e877421e..169e89ae 100644 --- a/storage/sql/config_test.go +++ b/storage/sql/config_test.go @@ -72,15 +72,20 @@ func TestPostgres(t *testing.T) { }, ConnectionTimeout: 5, } - conn, err := p.open() - if err != nil { - t.Fatal(err) + + // t.Fatal has a bad habbit of not actually printing the error + fatal := func(i interface{}) { + fmt.Fprintln(os.Stdout, i) + t.Fatal(i) } - defer conn.Close() newStorage := func() storage.Storage { + conn, err := p.open() + if err != nil { + fatal(err) + } if err := cleanDB(conn); err != nil { - t.Fatal(err) + fatal(err) } return conn }