From 42cd59aef4aaa81895b8ba6f0240f3a05d54e1e5 Mon Sep 17 00:00:00 2001
From: Bobby Rullo <bobby.rullo@coreos.com>
Date: Mon, 20 Jun 2016 10:20:14 -0700
Subject: [PATCH] client: differentiate error vs. nil result

When calling manager.Authenticate, logs now show different error
messages.
---
 client/manager/manager.go | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/client/manager/manager.go b/client/manager/manager.go
index fb5f51b0..3fefff41 100644
--- a/client/manager/manager.go
+++ b/client/manager/manager.go
@@ -168,7 +168,13 @@ func (m *ClientManager) SetDexAdmin(clientID string, isAdmin bool) error {
 
 func (m *ClientManager) Authenticate(creds oidc.ClientCredentials) (bool, error) {
 	clientSecret, err := m.clientRepo.GetSecret(nil, creds.ID)
-	if err != nil || clientSecret == nil {
+	if err != nil {
+		log.Errorf("error getting secret for client ID: %v: err: %v", creds.ID, err)
+		return false, nil
+	}
+
+	if clientSecret == nil {
+		log.Errorf("no secret found for client ID: %v", creds.ID)
 		return false, nil
 	}